ARROW-7117: [C++][CI] Fix the hanging C++ tests in Windows 2019#5915
ARROW-7117: [C++][CI] Fix the hanging C++ tests in Windows 2019#5915pitrou wants to merge 1 commit intoapache:masterfrom
Conversation
The fix is simply to use normal shared linking.
| ARROW_VERBOSE_THIRDPARTY_BUILD: OFF | ||
| steps: | ||
| - name: Disable Crash Dialogs | ||
| run: reg add "HKCU\SOFTWARE\Microsoft\Windows\Windows Error Reporting" /v DontShowUI /t REG_DWORD /d 1 /f |
There was a problem hiding this comment.
@kszucs Do you want me to put this in a script?
There was a problem hiding this comment.
This is quite environment specific so this is the right place.
There was a problem hiding this comment.
This can actually be useful on all Windows builders.
There was a problem hiding this comment.
Note this is not required for this PR, but was part of my investigations and can save future hassles.
There was a problem hiding this comment.
@pitrou then what was the solution? Just the linking or the hanging was just transient?
|
@pitrou Currently appveyor is the bottleneck for our overall CI times. What do you think about removing https://github.com/apache/arrow/blob/master/appveyor.yml#L65-L68 ? |
|
I'd rather move it to GH Actions :-) |
|
My question is about how can we reach feature parity with that build. |
|
Ah. Well, regardless of feature parity, there are different dimensions being tested:
So even if we enable features on the Win2019 build, we will still benefit from another build with Ninja and an older MSVC. |
|
Which MSVC version do we use on appveyor? |
|
The appveyor error is unrelated and probably transient, merging. |
|
Visual Studio 2015 on Windows Server 2012 is the oldest version, AFAIK. |
2 participants
The fix is simply to use normal shared linking.