Skip to content

ARROW-7523: [Developer] Relax clang-tidy check#6145

Closed
fsaintjacques wants to merge 1 commit intoapache:masterfrom
fsaintjacques:ARROW-7523-ignore-modernize-use-trailing-return-type
Closed

ARROW-7523: [Developer] Relax clang-tidy check#6145
fsaintjacques wants to merge 1 commit intoapache:masterfrom
fsaintjacques:ARROW-7523-ignore-modernize-use-trailing-return-type

Conversation

@fsaintjacques
Copy link
Copy Markdown
Contributor

@fsaintjacques fsaintjacques commented Jan 8, 2020

The following checks are removed due to verbosity

  • modernize-use-trailing-return-type
  • readability-*

@fsaintjacques fsaintjacques changed the title ARROW-7523: [Tools] Ignore modernize-use-trailing-return-type clang-tidy check ARROW-7523: [Tools] Relax clang-tidy check Jan 8, 2020
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 9, 2020

Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Can we remove readability-*?

@fsaintjacques
Copy link
Copy Markdown
Contributor Author

It does, I'll update the commit message.

@fsaintjacques
Copy link
Copy Markdown
Contributor Author

Do you mean you want to preserve readability-* and exclude it from the diff?

@kou
Copy link
Copy Markdown
Member

kou commented Jan 10, 2020

Ah, sorry.
I wanted to confirm that removing readability-* is expected because removing readability-* wasn't mentioned.

@kou kou changed the title ARROW-7523: [Tools] Relax clang-tidy check ARROW-7523: [Developer] Relax clang-tidy check Jan 10, 2020
@kou kou closed this in 53e951b Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants