Skip to content

ARROW-7518: [Python] Use PYARROW_WITH_HDFS when building wheels, conda packages#6203

Closed
kszucs wants to merge 4 commits intoapache:masterfrom
kszucs:ARROW-7518
Closed

ARROW-7518: [Python] Use PYARROW_WITH_HDFS when building wheels, conda packages#6203
kszucs wants to merge 4 commits intoapache:masterfrom
kszucs:ARROW-7518

Conversation

@kszucs
Copy link
Copy Markdown
Member

@kszucs kszucs commented Jan 15, 2020

No description provided.

@github-actions
Copy link
Copy Markdown

@kszucs
Copy link
Copy Markdown
Member Author

kszucs commented Jan 15, 2020

@ursabot crossbow submit -g wheel -g conda

@ursabot
Copy link
Copy Markdown

ursabot commented Jan 15, 2020

AMD64 Conda Crossbow Submit (#86614) builder has been succeeded.

Revision: 91f7968c5dd854a7c0db947248182419fa709dc7

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-435

Task Status
conda-linux-gcc-py27 Azure
conda-linux-gcc-py36 Azure
conda-linux-gcc-py37 Azure
conda-linux-gcc-py38 Azure
conda-osx-clang-py27 Azure
conda-osx-clang-py36 Azure
conda-osx-clang-py37 Azure
conda-osx-clang-py38 Azure
conda-win-vs2015-py36 Azure
conda-win-vs2015-py37 Azure
conda-win-vs2015-py38 Azure
wheel-manylinux1-cp27m Azure
wheel-manylinux1-cp27mu Azure
wheel-manylinux1-cp35m Azure
wheel-manylinux1-cp36m Azure
wheel-manylinux1-cp37m Azure
wheel-manylinux1-cp38 Azure
wheel-manylinux2010-cp27m Azure
wheel-manylinux2010-cp27mu Azure
wheel-manylinux2010-cp35m Azure
wheel-manylinux2010-cp36m Azure
wheel-manylinux2010-cp37m Azure
wheel-manylinux2010-cp38 Azure
wheel-manylinux2014-cp35m Azure
wheel-manylinux2014-cp36m Azure
wheel-manylinux2014-cp37m Azure
wheel-manylinux2014-cp38 Azure
wheel-osx-cp27m TravisCI
wheel-osx-cp35m TravisCI
wheel-osx-cp36m TravisCI
wheel-osx-cp37m TravisCI
wheel-osx-cp38 TravisCI
wheel-win-cp36m Appveyor
wheel-win-cp37m Appveyor
wheel-win-cp38 Appveyor

@kszucs
Copy link
Copy Markdown
Member Author

kszucs commented Jan 20, 2020

@ursabot crossbow submit -g wheel -g conda

@ursabot
Copy link
Copy Markdown

ursabot commented Jan 20, 2020

AMD64 Conda Crossbow Submit (#87338) builder has been succeeded.

Revision: 22eec34549c505811f715a50eeff42a9b3150556

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-440

Task Status
conda-linux-gcc-py27 Azure
conda-linux-gcc-py36 Azure
conda-linux-gcc-py37 Azure
conda-linux-gcc-py38 Azure
conda-osx-clang-py27 Azure
conda-osx-clang-py36 Azure
conda-osx-clang-py37 Azure
conda-osx-clang-py38 Azure
conda-win-vs2015-py36 Azure
conda-win-vs2015-py37 Azure
conda-win-vs2015-py38 Azure
wheel-manylinux1-cp27m Azure
wheel-manylinux1-cp27mu Azure
wheel-manylinux1-cp35m Azure
wheel-manylinux1-cp36m Azure
wheel-manylinux1-cp37m Azure
wheel-manylinux1-cp38 Azure
wheel-manylinux2010-cp27m Azure
wheel-manylinux2010-cp27mu Azure
wheel-manylinux2010-cp35m Azure
wheel-manylinux2010-cp36m Azure
wheel-manylinux2010-cp37m Azure
wheel-manylinux2010-cp38 Azure
wheel-manylinux2014-cp35m Azure
wheel-manylinux2014-cp36m Azure
wheel-manylinux2014-cp37m Azure
wheel-manylinux2014-cp38 Azure
wheel-osx-cp27m TravisCI
wheel-osx-cp35m TravisCI
wheel-osx-cp36m TravisCI
wheel-osx-cp37m TravisCI
wheel-osx-cp38 TravisCI
wheel-win-cp36m Appveyor
wheel-win-cp37m Appveyor
wheel-win-cp38 Appveyor

@kszucs
Copy link
Copy Markdown
Member Author

kszucs commented Jan 20, 2020

@ursabot crossbow submit -g wheel -g conda

@ursabot
Copy link
Copy Markdown

ursabot commented Jan 20, 2020

AMD64 Conda Crossbow Submit (#87385) builder has been succeeded.

Revision: 50ad951c897230c85933ef92085fed12decc0083

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-441

Task Status
conda-linux-gcc-py27 Azure
conda-linux-gcc-py36 Azure
conda-linux-gcc-py37 Azure
conda-linux-gcc-py38 Azure
conda-osx-clang-py27 Azure
conda-osx-clang-py36 Azure
conda-osx-clang-py37 Azure
conda-osx-clang-py38 Azure
conda-win-vs2015-py36 Azure
conda-win-vs2015-py37 Azure
conda-win-vs2015-py38 Azure
wheel-manylinux1-cp27m Azure
wheel-manylinux1-cp27mu Azure
wheel-manylinux1-cp35m Azure
wheel-manylinux1-cp36m Azure
wheel-manylinux1-cp37m Azure
wheel-manylinux1-cp38 Azure
wheel-manylinux2010-cp27m Azure
wheel-manylinux2010-cp27mu Azure
wheel-manylinux2010-cp35m Azure
wheel-manylinux2010-cp36m Azure
wheel-manylinux2010-cp37m Azure
wheel-manylinux2010-cp38 Azure
wheel-manylinux2014-cp35m Azure
wheel-manylinux2014-cp36m Azure
wheel-manylinux2014-cp37m Azure
wheel-manylinux2014-cp38 Azure
wheel-osx-cp27m TravisCI
wheel-osx-cp35m TravisCI
wheel-osx-cp36m TravisCI
wheel-osx-cp37m TravisCI
wheel-osx-cp38 TravisCI
wheel-win-cp36m Appveyor
wheel-win-cp37m Appveyor
wheel-win-cp38 Appveyor

@kszucs
Copy link
Copy Markdown
Member Author

kszucs commented Jan 20, 2020

@ursabot build

@kszucs
Copy link
Copy Markdown
Member Author

kszucs commented Jan 20, 2020

@ursabot crossbow submit conda-linux-gcc-py27

@kszucs
Copy link
Copy Markdown
Member Author

kszucs commented Jan 20, 2020

AMD64 Conda Crossbow Submit (#87415) builder has been succeeded.

Revision: 50ad951c897230c85933ef92085fed12decc0083

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-442

Task Status
conda-linux-gcc-py27 Azure

@kszucs
Copy link
Copy Markdown
Member Author

kszucs commented Jan 20, 2020

@ursabot crossbow submit -g wheel -g conda

@kszucs
Copy link
Copy Markdown
Member Author

kszucs commented Jan 20, 2020

AMD64 Conda Crossbow Submit (#87416) builder has been succeeded.

Revision: 50ad951c897230c85933ef92085fed12decc0083

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-443

Task Status
conda-linux-gcc-py27 Azure
conda-linux-gcc-py36 Azure
conda-linux-gcc-py37 Azure
conda-linux-gcc-py38 Azure
conda-osx-clang-py27 Azure
conda-osx-clang-py36 Azure
conda-osx-clang-py37 Azure
conda-osx-clang-py38 Azure
conda-win-vs2015-py36 Azure
conda-win-vs2015-py37 Azure
conda-win-vs2015-py38 Azure
wheel-manylinux1-cp27m Azure
wheel-manylinux1-cp27mu Azure
wheel-manylinux1-cp35m Azure
wheel-manylinux1-cp36m Azure
wheel-manylinux1-cp37m Azure
wheel-manylinux1-cp38 Azure
wheel-manylinux2010-cp27m Azure
wheel-manylinux2010-cp27mu Azure
wheel-manylinux2010-cp35m Azure
wheel-manylinux2010-cp36m Azure
wheel-manylinux2010-cp37m Azure
wheel-manylinux2010-cp38 Azure
wheel-manylinux2014-cp35m Azure
wheel-manylinux2014-cp36m Azure
wheel-manylinux2014-cp37m Azure
wheel-manylinux2014-cp38 Azure
wheel-osx-cp27m TravisCI
wheel-osx-cp35m TravisCI
wheel-osx-cp36m TravisCI
wheel-osx-cp37m TravisCI
wheel-osx-cp38 TravisCI
wheel-win-cp36m Appveyor
wheel-win-cp37m Appveyor
wheel-win-cp38 Appveyor

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#!/bin/bash
#!/bin/bash

This looks like an accident

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, thanks for spotting that!

@kszucs
Copy link
Copy Markdown
Member Author

kszucs commented Jan 22, 2020

@ursabot crossbow submit -g wheel

@kszucs
Copy link
Copy Markdown
Member Author

kszucs commented Jan 22, 2020

AMD64 Conda Crossbow Submit (#87615) builder has been succeeded.

Revision: 77311b8bea246560478145eb112f27662f9eb45c

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-446

Task Status
wheel-manylinux1-cp27m Azure
wheel-manylinux1-cp27mu Azure
wheel-manylinux1-cp35m Azure
wheel-manylinux1-cp36m Azure
wheel-manylinux1-cp37m Azure
wheel-manylinux1-cp38 Azure
wheel-manylinux2010-cp27m Azure
wheel-manylinux2010-cp27mu Azure
wheel-manylinux2010-cp35m Azure
wheel-manylinux2010-cp36m Azure
wheel-manylinux2010-cp37m Azure
wheel-manylinux2010-cp38 Azure
wheel-manylinux2014-cp35m Azure
wheel-manylinux2014-cp36m Azure
wheel-manylinux2014-cp37m Azure
wheel-manylinux2014-cp38 Azure
wheel-osx-cp27m TravisCI
wheel-osx-cp35m TravisCI
wheel-osx-cp36m TravisCI
wheel-osx-cp37m TravisCI
wheel-osx-cp38 TravisCI
wheel-win-cp36m Appveyor
wheel-win-cp37m Appveyor
wheel-win-cp38 Appveyor

@kszucs
Copy link
Copy Markdown
Member Author

kszucs commented Jan 22, 2020

The windows errors should be resolved by #6242

@kszucs
Copy link
Copy Markdown
Member Author

kszucs commented Jan 23, 2020

@ursabot crossbow submit -g wheel -g conda

@kszucs
Copy link
Copy Markdown
Member Author

kszucs commented Jan 23, 2020

AMD64 Conda Crossbow Submit (#87965) builder has been succeeded.

Revision: 6dd82a6

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-450

Task Status
conda-linux-gcc-py27 Azure
conda-linux-gcc-py36 Azure
conda-linux-gcc-py37 Azure
conda-linux-gcc-py38 Azure
conda-osx-clang-py27 Azure
conda-osx-clang-py36 Azure
conda-osx-clang-py37 Azure
conda-osx-clang-py38 Azure
conda-win-vs2015-py36 Azure
conda-win-vs2015-py37 Azure
conda-win-vs2015-py38 Azure
wheel-manylinux1-cp27m Azure
wheel-manylinux1-cp27mu Azure
wheel-manylinux1-cp35m Azure
wheel-manylinux1-cp36m Azure
wheel-manylinux1-cp37m Azure
wheel-manylinux1-cp38 Azure
wheel-manylinux2010-cp27m Azure
wheel-manylinux2010-cp27mu Azure
wheel-manylinux2010-cp35m Azure
wheel-manylinux2010-cp36m Azure
wheel-manylinux2010-cp37m Azure
wheel-manylinux2010-cp38 Azure
wheel-manylinux2014-cp35m Azure
wheel-manylinux2014-cp36m Azure
wheel-manylinux2014-cp37m Azure
wheel-manylinux2014-cp38 Azure
wheel-osx-cp27m TravisCI
wheel-osx-cp35m TravisCI
wheel-osx-cp36m TravisCI
wheel-osx-cp37m TravisCI
wheel-osx-cp38 TravisCI
wheel-win-cp36m Appveyor
wheel-win-cp37m Appveyor
wheel-win-cp38 Appveyor

@kszucs
Copy link
Copy Markdown
Member Author

kszucs commented Jan 23, 2020

The coda-win failures should be resolved by #6242
And we should deal with the OSX-wheel failures in a follow-up PR.

@kszucs kszucs requested review from kou and nealrichardson January 23, 2020 19:40
-DARROW_BUILD_SHARED=ON \
-DARROW_BUILD_STATIC=OFF \
-DARROW_BOOST_USE_SHARED=ON \
-DARROW_BUILD_TESTS=OFF \
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just sorted the options alphabetically.

Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kszucs
Copy link
Copy Markdown
Member Author

kszucs commented Jan 24, 2020

@ursabot crossbow submit -g conda

@kszucs
Copy link
Copy Markdown
Member Author

kszucs commented Jan 24, 2020

AMD64 Conda Crossbow Submit (#88151) builder has been succeeded.

Revision: 1e3f091

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-455

Task Status
conda-linux-gcc-py27 Azure
conda-linux-gcc-py36 Azure
conda-linux-gcc-py37 Azure
conda-linux-gcc-py38 Azure
conda-osx-clang-py27 Azure
conda-osx-clang-py36 Azure
conda-osx-clang-py37 Azure
conda-osx-clang-py38 Azure
conda-win-vs2015-py36 Azure
conda-win-vs2015-py37 Azure
conda-win-vs2015-py38 Azure

Copy link
Copy Markdown
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks for doing this

cmake \
-DCMAKE_BUILD_TYPE=Release \
-DARROW_BOOST_USE_SHARED=ON \
-DARROW_BUILD_SHARED=ON \
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in the scope for this PR, but should we add ARROW_BUILD_STATIC=OFF here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, merging now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants