ARROW-6393: [C++] Add EqualOptions support in SparseTensor::Equals#6443
Closed
mrkn wants to merge 10 commits intoapache:masterfrom
Closed
ARROW-6393: [C++] Add EqualOptions support in SparseTensor::Equals#6443mrkn wants to merge 10 commits intoapache:masterfrom
mrkn wants to merge 10 commits intoapache:masterfrom
Conversation
mrkn
force-pushed
the
ARROW-6393
branch
3 times, most recently
from
d5ea290 to
9ba7b09
Compare
mrkn
force-pushed
the
ARROW-6393
branch
3 times, most recently
from
3e7a709 to
e9ddb8f
Compare
Member
Author
|
This failure seems not related to this pull-request. |
Member
Author
mrkn
changed the title
Member
|
@mrkn will do :) |
rok
reviewed
Feb 23, 2020
Member
rok
left a comment
rok
left a comment
There was a problem hiding this comment.
Looks good to me. I'm just wondering about Float to Floating name change.
pitrou
requested changes
Feb 24, 2020
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
Looks good on the principle, just some minor comments.
mrkn
commented
Feb 26, 2020
| } | ||
|
|
||
| template <typename DataType> | ||
| bool FloatSparseTensorDataEquals(const typename DataType::c_type* left_data, |
Member
Author
There was a problem hiding this comment.
I renamed Floating to Float here and other places in this pull-request.
But I didn't rename Floating outside of this pull-request, such as BaseFloatingEquals at the top of this file.
pitrou
approved these changes
Feb 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.