ARROW-6895: [C++][Parquet] Do not reset dictionary in ByteArrayDictionaryRecordReader during incremental reads#6460
Closed
adamhooper wants to merge 3 commits intoapache:masterfrom
Closed
ARROW-6895: [C++][Parquet] Do not reset dictionary in ByteArrayDictionaryRecordReader during incremental reads#6460adamhooper wants to merge 3 commits intoapache:masterfrom
adamhooper wants to merge 3 commits intoapache:masterfrom
Conversation
wesm
changed the title
Member
|
I changed the PR title, it seems like (unless I've misunderstood) the issue is about incremental reads using this code path, and our current unit tests only test all-or-nothing reads of row groups. So we should write some unit tests with incremental reads that exhibit the problem |
Previously, ByteArrayDictionaryRecordReader would clear the dictionary after returning a chunk. Now, it persists the dictionary in case a future chunk needs it.
Member
|
I just added a unit test to verify the fix. Thanks @adamhooper for the fix |
Member
|
+1. The CI failures are unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, ByteArrayDictionaryRecordReader would clear the dictionary
after returning a chunk. Now, it persists the dictionary in case a
future chunk needs it.
Sorry -- I feel I'm missing the expertise to write a unit test. But I can attest that in Arrow 0.16 the code snippet in ARROW-6895 segfaults on the
bad.parquetattached to that issue; and after this patch, it works correctly.