ARROW-7785: [C++] Improve compilation performance of sparse tensor related code#6533
Closed
mrkn wants to merge 7 commits intoapache:masterfrom
Closed
ARROW-7785: [C++] Improve compilation performance of sparse tensor related code#6533mrkn wants to merge 7 commits intoapache:masterfrom
mrkn wants to merge 7 commits intoapache:masterfrom
Conversation
Member
Author
|
This is the result of ClangBuildAnalyzer. Before: After: |
Member
|
Would you have the timings in release mode? |
Member
Author
|
This is the result on release mode. I need additional work to reduce the codegen time of Before: After: |
mrkn
changed the title
Member
|
Yes, the main problem is the codegen time in this case. I would hope it's possible to make some portions non-templated and only keep the hot conversion loops as template functions. |
Member
Author
|
Finally, I got the following result. |
mrkn
changed the title
Member
Author
|
@pitrou Could you review this again? |
wesm
reviewed
Mar 6, 2020
Member
Author
There was a problem hiding this comment.
I added a commit to fix for IWYU, but the following reports are remaining. I guess these reports are false positive.
include-what-you-use 0.13 (git:06e88ef) based on clang version 9.0.0-2~ubuntu18.04.2 (tags/RELEASE_900/final)
/home/mrkn/src/github.com/apache/arrow/cpp/src/arrow/tensor/csf_converter.cc should add these lines:
namespace arrow { template <typename T, typename Enable = void> class TypedBufferBuilder; }
/home/mrkn/src/github.com/apache/arrow/cpp/src/arrow/tensor/csf_converter.cc should remove these lines:
- #include "arrow/buffer_builder.h" // lines 27-27
Member
Author
|
@wesm Thank you for reviewing this. I've added commits to fix things you pointed out. |
wesm
approved these changes
Mar 6, 2020
Member
wesm
left a comment
wesm
left a comment
There was a problem hiding this comment.
+1 I fixed the linting issues and did some minor cleaning of the includes. Thanks for addressing my comments!
wesm
changed the title
Member
|
Here's an appveyor build on my fork: https://ci.appveyor.com/project/wesm/arrow/builds/31299374 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract
SparseTensorConverterrelated things fromsparse_tensor.cctotensor/converter.ccand break into multiple compilation units which can be compiled in parallel. This should reduce the code wall clock time of compilingsparse_tensor.cc.