ARROW-4018: [C++] Fix RLE tests' failures on big-endian platforms#7144
Closed
kiszk wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-4018: [C++] Fix RLE tests' failures on big-endian platforms#7144kiszk wants to merge 2 commits intoapache:masterfrom
kiszk wants to merge 2 commits intoapache:masterfrom
Conversation
Member
Author
|
This failure may not be related to this PR. |
pitrou
reviewed
May 11, 2020
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
Thank you. Just a question below.
| @@ -31,6 +31,7 @@ namespace internal { | |||
|
|
|||
| inline const uint32_t* unpack1_32(const uint32_t* in, uint32_t* out) { | |||
| uint32_t inl = util::SafeLoad(in); | |||
| inl = arrow::BitUtil::ToLittleEndian(inl); | |||
Member
There was a problem hiding this comment.
Shouldn't this be FromLittleEndian? (it will produce the same code, but it seems logically more accurate)
Member
Author
There was a problem hiding this comment.
Ah, you are right! I will update it soon.
Member
|
Thank you very much @kiszk ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds big-endian support in RLE related classes. The data for RLE is stored using a little-endian format. The current code assumes a little-endian CPU in two places.
RleDecoder::NextCounts(fix was proposed in ARROW-4018)After applying #7136 & this PR, the following failures in arrow-utility-test's failures will be fixed.