Skip to content

ARROW-7910: [C++] Add internal GetPageSize() function #7155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pitrou wants to merge 1 commit into from
Closed

ARROW-7910: [C++] Add internal GetPageSize() function #7155

pitrou wants to merge 1 commit into from

Conversation

@pitrou
Copy link
Member

@pitrou pitrou commented May 12, 2020

No description provided.

@pitrou
Copy link
Member Author

pitrou commented May 12, 2020

@kiszk You might check this.

@github-actions
Copy link

github-actions bot commented May 12, 2020

https://issues.apache.org/jira/browse/ARROW-7910

@pitrou
Copy link
Member Author

pitrou commented May 12, 2020

Well, the ARM and s390x tests succeeded at least.

@kiszk
Copy link
Member

kiszk commented May 12, 2020

Let me run on ppc64.

@kiszk
Copy link
Member

kiszk commented May 12, 2020

Succeeded on ppc64 (big-endian), too.

[----------] 1 test from GetPageSize
[ RUN      ] GetPageSize.Basics
[       OK ] GetPageSize.Basics (0 ms)
[----------] 1 test from GetPageSize (0 ms total)

@kiszk
Copy link
Member

kiszk commented May 12, 2020

LGTM

fsaintjacques
fsaintjacques approved these changes May 12, 2020
View reviewed changes
cpp/src/arrow/util/io_util.cc
errno = 0;
const auto ret = sysconf(_SC_PAGESIZE);
if (ret == -1) {
ARROW_LOG(FATAL) << "sysconf(_SC_PAGESIZE) failed: " << ErrnoMessage(errno);
Copy link
Contributor

@fsaintjacques fsaintjacques May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just return 4k?

Copy link
Member Author

@pitrou pitrou May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather know in which conditions this syscall fails (it should never).

@pitrou pitrou deleted the ARROW-7910-page-size branch May 12, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fsaintjacques fsaintjacques fsaintjacques approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pitrou @kiszk @fsaintjacques