Skip to content

Conversation

@bkietz
Copy link
Member

@bkietz bkietz commented May 14, 2020

No description provided.

@github-actions
Copy link

@bkietz
Copy link
Member Author

bkietz commented May 14, 2020

@emkornfield
Copy link
Contributor

@bkietz could you add a unit test?

@bkietz bkietz force-pushed the 8799-Reading-list-column-as-ne branch from 9471840 to 7a92315 Compare June 1, 2020 15:35
@bkietz
Copy link
Member Author

bkietz commented Jun 1, 2020

@emkornfield @wesm In adding a unit test I've become uncertain of the ColumnReader contract and whether my solution upholds it

If modifying NestedListReader as I have here is unsatisfactory, I could change TransferDictionary to ensure LeafReader yields ChunkedArray{nullptr} when its out of data. What do you think?

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 -- I think this is a band-aid solution until all these code can be deleted in favor of a complete nested data reading implementation. Just to confirm this fixes ARROW-8799 and so this is OK to merge?

@bkietz
Copy link
Member Author

bkietz commented Jun 8, 2020

Confirmed, this resolves the issue

@wesm wesm closed this in 5c8f215 Jun 8, 2020
@bkietz bkietz deleted the 8799-Reading-list-column-as-ne branch February 25, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants