ARROW-8485: [Integration][Java] Implement extension types integration#7270
ARROW-8485: [Integration][Java] Implement extension types integration#7270rymurr wants to merge 1 commit intoapache:masterfrom
Conversation
|
@lidavidm you mentioned previously you weren't totally happy with the existing implementation of extension types in Java. Is that still the case and is it wise to explicitly enable in integration if the data type isn't ready? |
|
@rymurr I admit I've completely forgotten what my complaint was 😂 Have you or anyone else been using it? I'd only be worried if it seemed like the feature wasn't being used at all. |
|
I am not using it, just trying to clean up some of the outstanding integration tests before the v1.0.0 release. This particular integration test requires no changes to the extension type vector so it does give me confidence in Extension types in that they are compatible w/ C++ IPC. However perhaps there is a way to mark the type as working but not extensively tested? |
|
I think we can enable it and if we later decide we want to rework the implementation or API, this will give us a baseline to compare with. |
This enables integration tests for extension types after custom metadata is fixed apache#7269
|
I'll leave this up for a bit before merging so others can look, but otherwise this is exciting! |
This enables integration tests for extension types after custom metadata is fixed apache#7269 Closes apache#7270 from rymurr/ARROW-8485 Authored-by: Ryan Murray <rymurr@dremio.com> Signed-off-by: David Li <li.davidm96@gmail.com>
3 participants
This enables integration tests for extension types after custom metadata is fixed #7269