ARROW-9486: [C++][Dataset] Support implicit cast of InExpression::set to dict#7776
Closed
bkietz wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-9486: [C++][Dataset] Support implicit cast of InExpression::set to dict#7776bkietz wants to merge 1 commit intoapache:masterfrom
bkietz wants to merge 1 commit intoapache:masterfrom
Conversation
pitrou
reviewed
Jul 15, 2020
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
Why not, but I can't rely evaluate the consequences.
| return null(); | ||
| } | ||
|
|
||
| Result<Datum> CastOrDictionaryEncode(const Datum& arr, |
Member
There was a problem hiding this comment.
This doesn't seem to be static nor in the anonymous namespace?
(ditto for other private functions in this file?)
Member
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.