ARROW-1154: [C++] Import miscellaneous computational utility code from parquet-cpp #785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Id761068793f6b6e0ece1741349693ecd30ae6b67
Change-Id: Ia313f8673be451982b2e5952f17d2676ecb24dea
Change-Id: I7667374393ba7f064aa125de1d2e4532e37479d0
asfgit
pushed a commit
to apache/parquet-cpp
that referenced
this pull request
Jun 27, 2017
…-1154 I verified locally that this works on Linux with the current iteration of apache/arrow#785, will update the commit in ThirdpartyToolchain.cmake after that is merged to get a passing build Author: Wes McKinney <wes.mckinney@twosigma.com> Closes #364 from wesm/PARQUET-1045 and squashes the following commits: fede8d9 [Wes McKinney] Update Arrow version to include ARROW-1159 b44b4ab [Wes McKinney] Fix benchmark. Only build Zlib on Windows when building Thrift 83d2289 [Wes McKinney] Update Arrow version 8914c16 [Wes McKinney] Remove code that was moved to Apache Arrow, refactoring
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
…-1154 I verified locally that this works on Linux with the current iteration of apache#785, will update the commit in ThirdpartyToolchain.cmake after that is merged to get a passing build Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#364 from wesm/PARQUET-1045 and squashes the following commits: fede8d9 [Wes McKinney] Update Arrow version to include ARROW-1159 b44b4ab [Wes McKinney] Fix benchmark. Only build Zlib on Windows when building Thrift 83d2289 [Wes McKinney] Update Arrow version 8914c16 [Wes McKinney] Remove code that was moved to Apache Arrow, refactoring Change-Id: Ibee94d0dd9d0b6844bdbb3c57da5126c97760108
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will make a corresponding PR to parquet-cpp to ensure that this code migration is complete enough.