ARROW-1166: Fix errors in example and missing reference in Layout.md#795
Closed
fangzheng wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-1166: Fix errors in example and missing reference in Layout.md#795fangzheng wants to merge 1 commit intoapache:masterfrom
fangzheng wants to merge 1 commit intoapache:masterfrom
Conversation
wesm
approved these changes
Jun 29, 2017
| * Length: 4, Null count: 0 | ||
| * Null bitmap buffer: Not required | ||
| * Length: 4, Null count: 1 | ||
| * Null bitmap buffer: |
Member
There was a problem hiding this comment.
I think this is OK, but strictly speaking it would be valid for the null count to be 0, and for the 3rd value slot to be some value. So what was here before was not incorrect (except for the missing padding bytes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.