ARROW-9849: [Rust] [DataFusion] Simplified argument types of ScalarFunctions. #8045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecates "Field" as argument to the UDF declaration, since we were only using its type.
Member
Author
|
FYI @andygrove and @alamb |
Member
|
Could you please add the JIRA number and the category to the title? |
jorgecarleitao
changed the title
Member
Author
wops. Thanks @kiszk , forgot about it. |
alamb
approved these changes
Aug 25, 2020
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
It makes sense to me to remove the names from the input arguments (as the arguments come from other expressions, not (directly) from the output of the previous ExecutionPlan).
👍
andygrove
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates "Field" as argument to the UDF declaration, since we are only using its type.
This is a spin-off of #8032 with a much smaller scope, as the other one is getting to large to handle.