Skip to content

Conversation

@wesm
Copy link
Member

@wesm wesm commented Jul 3, 2017

No description provided.

Change-Id: Iaed4399ae45565668bf7e87d4ffbf48959c07339
Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@asfgit asfgit closed this in 7c18ddd Jul 4, 2017
@wesm wesm deleted the ARROW-966 branch July 4, 2017 15:32
xxlaykxx pushed a commit to xxlaykxx/arrow that referenced this pull request Oct 2, 2025
## What's Changed

Apply pre-commit since I forgot.

(cherry picked from commit e4f64269db0a08299fa25be491570be5ba71d623)
xxlaykxx added a commit to dremio/arrow that referenced this pull request Oct 3, 2025
* apacheGH-725: Added ExtensionReader (apache#726)

## What's Changed
ExtensionReader was added to support reading extension types from a
complex vector.
It contains **read(ExtensionHolder)** method for reading to the holder.
And **readObject** - for reading the value explicitly.

Closes apache#725.

(cherry picked from commit e6da71e871a3678a737a88dbe79491b4111496b4)

* MINOR: Fix format (apache#809)

## What's Changed

Apply pre-commit since I forgot.

(cherry picked from commit e4f64269db0a08299fa25be491570be5ba71d623)

* apacheGH-836: Added support of ExtensionType for ComplexCopier (apache#837)

## What's Changed

Updated ComplexCopier to support ExtensionType - it contains two
**copy** methods
```
public static void copy(FieldReader input, FieldWriter output) //for not breaking  existing logic

public static void copy(FieldReader input, FieldWriter output, ExtensionTypeWriterFactory extensionTypeWriterFactory)
```
Also updated ComplexCopier tests.
Closes apache#836.

(cherry picked from commit 34060eb491a870f5ede5d30e007060b8310dc64f)

* fix after merge

* fix after macos build

* fix after macos build

* fix macos build

* fix macos build

* fix macos build

* fix after merge

---------

Co-authored-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants