ARROW-1190: [JAVA] Fixing VectorLoader for duplicate field names #816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Is it possible to add a unit test for this? |
Contributor
Author
|
unit test added |
antonymayi
changed the title
antonymayi
changed the title
xhochy
approved these changes
Jul 17, 2017
Member
xhochy
left a comment
xhochy
left a comment
There was a problem hiding this comment.
+1, thank you for fixing this!
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
VectorLoader was corrupting data when some of the fields had same name in which case only one of that vectors got properly loaded. This PR resolves the problem by avoiding by-name field lookups. Author: Antony Mayi <antonymayi@yahoo.com> Closes apache#816 from antonymayi/master and squashes the following commits: 38c1837 [Antony Mayi] adding unit test for unload-loading vectors with duplicate field names a723416 [Antony Mayi] ARROW-1190 - fixing VectorLoader for duplicate field names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VectorLoader was corrupting data when some of the fields had same name in which case only one of that vectors got properly loaded. This PR resolves the problem by avoiding by-name field lookups.