ARROW-1216: [Python] Fix creating numpy array from arrow buffers on python 2#844
Closed
pcmoritz wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-1216: [Python] Fix creating numpy array from arrow buffers on python 2#844pcmoritz wants to merge 2 commits intoapache:masterfrom
pcmoritz wants to merge 2 commits intoapache:masterfrom
Conversation
xhochy
approved these changes
Jul 15, 2017
Member
xhochy
left a comment
xhochy
left a comment
There was a problem hiding this comment.
+1, LGTM. I'll merge on green build.
Thanks for fixing this so quickly!
Contributor
Author
|
No problem! It's a little unfortunate that numpy doesn't support the new buffer protocol (seems like in python 2.7 that would be possible in principle). |
wesm
reviewed
Jul 15, 2017
| byte_array[0] = 42 | ||
| buf = pa.frombuffer(byte_array) | ||
| array = np.frombuffer(buf, dtype="uint8") | ||
| assert array[0] == byte_array[0] |
Member
There was a problem hiding this comment.
Can you verify that this sets the array's base member?
Contributor
Author
There was a problem hiding this comment.
@wesm Thanks for the note, I added the check and the tests have passed.
pcmoritz
changed the title
xhochy
approved these changes
Jul 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.