-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-10269: [Rust] Update to 2020-11-14 nightly #8666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We have over 100 warnings, which cause too much noise
|
FYI @vertexclique |
|
Segfault on the coverage, outch :/ |
I want to look at whether we can use the new llvm-based coverage instead of tarpaulin |
The failure was from a newer version of `cargo-tarpaulin`
Found and fixed the problem. We were using an older cached version of We should be good to go @jorgecarleitao |
Codecov Report
@@ Coverage Diff @@
## master #8666 +/- ##
==========================================
- Coverage 84.84% 84.55% -0.30%
==========================================
Files 165 177 +12
Lines 43322 43567 +245
==========================================
+ Hits 36757 36838 +81
- Misses 6565 6729 +164
Continue to review full report at Codecov.
|
jorgecarleitao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks a lot @nevi-me , cool fixes to the code also.
vertexclique
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this Neville!
|
Do we wait for some of the PRs to be flushed, or do we merge this? |
|
I don't see this being a big risk to open PRs (as some already have merge conflicts). We run 36 CI jobs for this, vs the normal 8; so maybe there's an efficiency argument in merging this sooner, instead of having to rebase later (which I don't mind doing). |
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 -- thank you @nevi-me
FYI I filed https://issues.apache.org/jira/browse/ARROW-10597 to track enablign clippy lints in datafusion
|
@alamb thanks. A quick solution for many of the lints, is to run clippy-fix with -Z unstable-options, so that one doesn't manually fix them. |
This takes us from 2020-04-22 to 2020-11-14.
There have been a lot of clippy lints introduced since April, and an incompleteness feature warning about specialization (which causes CI to fail).
I have allowed almost all clippy lints in datafusion, as we have >150 warnings there.
I have made changes to fix arrow and parquet lints where I perceive them not to affect open PRs.