ARROW-10690: [Java] Fix ComplexCopier bug for list vector#8742
Closed
projjal wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-10690: [Java] Fix ComplexCopier bug for list vector#8742projjal wants to merge 2 commits intoapache:masterfrom
projjal wants to merge 2 commits intoapache:masterfrom
Conversation
tvamsikalyan
approved these changes
Nov 23, 2020
tvamsikalyan
left a comment
tvamsikalyan
left a comment
There was a problem hiding this comment.
This looks good to me.
If caller is expecting to reuse ListVector and start the list at an index less than what was previously written, then we are adjusting the state of lastSet index.
Contributor
|
For the second example in the discussion, the result should be [[1, 2], [7, 8]]? |
Contributor
Author
You are right. I miswrote that part. Updated the description. |
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
When copying a list vector using ComplexCopier, if the target list vector is non-empty, the result vector is incorrect. For example, if src = [[1,2], [3, 4]], tgt = [[5, 6], [7, 8]], copying src to tgt gives tgt = [[5, 6, 1, 2], [3, 4]] instead of [[1,2], [3, 4]] Similary when using copyFrom(/Safe) method if the vector at the index is non-empty, the listElement is appended instead. For above src and tgt vector, tgt.copyFrom(0, 0, src) gives [[5, 6, 1, 2], []] instead of [[1,2], [7, 8]] Closes apache#8742 from projjal/listcomplexcopier and squashes the following commits: 1531319 <Projjal Chanda> move condition from list writer writer to list vector 71112eb <Projjal Chanda> fix complex copier Authored-by: Projjal Chanda <iam@pchanda.com> Signed-off-by: Praveen <praveen@dremio.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When copying a list vector using ComplexCopier, if the target list vector is non-empty, the result vector is incorrect. For example, if src = [[1,2], [3, 4]], tgt = [[5, 6], [7, 8]], copying src to tgt gives tgt = [[5, 6, 1, 2], [3, 4]] instead of [[1,2], [3, 4]]
Similary when using copyFrom(/Safe) method if the vector at the index is non-empty, the listElement is appended instead. For above src and tgt vector, tgt.copyFrom(0, 0, src) gives [[5, 6, 1, 2], []] instead of [[1,2], [7, 8]]