ARROW-10704: [Rust][DataFusion] Remove Nested from expression enum#8750
Closed
Dandandan wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-10704: [Rust][DataFusion] Remove Nested from expression enum#8750Dandandan wants to merge 1 commit intoapache:masterfrom
Dandandan wants to merge 1 commit intoapache:masterfrom
Conversation
jorgecarleitao
approved these changes
Nov 23, 2020
Member
jorgecarleitao
left a comment
jorgecarleitao
left a comment
There was a problem hiding this comment.
Nice simplification :)
Member
|
Could you rebase, please? |
Dandandan
force-pushed
the
remove_nested_expr
branch
from
5158537 to
fe43103
Compare
Contributor
Author
|
@jorgecarleitao Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
Nested(Box<Expr>),fromExpr.This is not used / produced ever, and I think this will also never be needed, as you can always have it "unnested" as well.