ARROW-11288: [Rust][DataFusion] Update hashbrown to 0.10 #9231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jan 17, 2021
alamb
reviewed
Jan 19, 2021
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
I checked this out locally (and merged to master) and tried to verify that it passes -- sadly, when I did Rust refused to compile it ...
Submodule path '../cpp/submodules/parquet-testing': checked out 'e31fe1a02c9e9f271e4bfb8002d403c52f1ef8eb'
(arrow_dev) alamb@ip-192-168-0-182:~/Software/arrow/rust$ cargo test --all
Updating crates.io index
error: failed to select a version for the requirement `hashbrown = "^0.10"`
candidate versions found which didn't match: 0.9.1, 0.9.0, 0.8.2, ...
location searched: crates.io index
required by package `datafusion v3.0.0-SNAPSHOT (/Users/alamb/Software/arrow/rust/datafusion)`
Contributor
Author
|
@alamb thanks for the heads up! Seems 0.10 was yanked on crates.io, I think because of a discovered bug. Let's wait to merge this once there is a new release. |
Contributor
|
Closing this PR until the new hashbrown release is available (I am trying to reduce the backlog) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing big has changed, has some small performance tweaks + keeps it up to date.