ARROW-1310: [JAVA] revert changes made in ARROW-886 #937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elahrvivaz
approved these changes
Aug 3, 2017
Member
|
Is there any way to assert the correct behavior in a unit test? |
Contributor
Author
|
Looks like we have realloc related unit tests in TestVectorRealloc.java. But as a follow-up, I am planning to revisit realloc related tests and add to/enhance them. |
Member
|
OK, no problem |
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
@elahrvivaz , @StevenMPhillips Reverting the changes made for ARROW-886 -- apache#591 (1) Don't explicitly reallocate the offsetVector in realloc() function of Variable Length Vectors. If we call setSafe() on variable length vector, it will internally invoke setSafe() on the corresponding offsetVector and the latter function can decide whether to reallocate the offsetVector or not. (2) Doing (1) will break the unit test added as part of PR 591 so we need to remove that as well. Author: siddharth <siddharth@dremio.com> Closes apache#937 from siddharthteotia/ARROW-1310 and squashes the following commits: c5a2707 [siddharth] ARROW-1310: revert changes made in ARROW-886
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@elahrvivaz , @StevenMPhillips
Reverting the changes made for ARROW-886 -- #591
(1) Don't explicitly reallocate the offsetVector in realloc() function of Variable Length Vectors. If we call setSafe() on variable length vector, it will internally invoke setSafe() on the corresponding offsetVector and the latter function can decide whether to reallocate the offsetVector or not.
(2) Doing (1) will break the unit test added as part of PR 591 so we need to remove that as well.