ARROW-1309: [Python] Handle nested lists with all None values in Array.from_pandas#947
Closed
wesm wants to merge 3 commits intoapache:masterfrom
Closed
ARROW-1309: [Python] Handle nested lists with all None values in Array.from_pandas#947wesm wants to merge 3 commits intoapache:masterfrom
wesm wants to merge 3 commits intoapache:masterfrom
Conversation
Change-Id: Iffa7511f223dcfa0e81099f84e20e73fa0bbad9a
Change-Id: I222934709b134d08ccdfb8181c0c6fd1b5574718
Change-Id: I00d47a8decf872a7688a036528b3f24565917700
Member
Author
|
+1. This is failing due to ARROW-1338, unrelated to this |
xhochy
reviewed
Aug 8, 2017
| return Status::NotImplemented("mask not supported in object conversions yet"); | ||
| } | ||
|
|
||
| if (is_strided()) { |
Member
There was a problem hiding this comment.
Do we have a failing test that checks support for strided arrays?
Member
Author
There was a problem hiding this comment.
It looks like not. I'll add one, since we should be using
for this iteration rather than going directly toPyArray_DATA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.