ARROW-1336: [C++] Add arrow::schema factory function, simply some awkward constructors #948
Closed
wesm wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-1336: [C++] Add arrow::schema factory function, simply some awkward constructors #948wesm wants to merge 1 commit intoapache:masterfrom
wesm wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
cc @cpcloud I'm not sure why Appveyor is upset |
…initializer list Change-Id: Ia82a946f549c5b28ffad20ae4a0014d007e098de
Contributor
|
Have you considered naming it make_schema? That'd go well with std::make_unique, std::make_shared, std::make_pair, etc; then you can also get rid of ::arrow:: (I assume that was to avoid name clashes). |
Member
Author
|
@pcmoritz I did think of that; this is more consistent with functions like I wonder what is going on with the segfault in Travis CI, we should try to figure that out (I have seen it before): opned ARROW-1338 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.