Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Feb 18, 2021

I am messing around with OptimizerRule for some experiments, and found myself clarifying the comments each time... So I figured I would at least get the doc changes queued for inclusion

@github-actions
Copy link

Copy link
Contributor

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov-io
Copy link

Codecov Report

Merging #9529 (09b3027) into master (bca7d2f) will increase coverage by 0.03%.
The diff coverage is 91.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9529      +/-   ##
==========================================
+ Coverage   82.24%   82.27%   +0.03%     
==========================================
  Files         244      244              
  Lines       55289    55371      +82     
==========================================
+ Hits        45470    45555      +85     
+ Misses       9819     9816       -3     
Impacted Files Coverage Δ
rust/arrow/src/compute/kernels/comparison.rs 95.84% <ø> (ø)
rust/arrow/src/json/reader.rs 83.63% <89.89%> (+0.81%) ⬆️
rust/arrow/src/compute/kernels/cast.rs 97.28% <100.00%> (+0.04%) ⬆️
rust/datafusion/src/physical_plan/limit.rs 57.47% <100.00%> (-0.49%) ⬇️
rust/datafusion/src/physical_plan/planner.rs 79.58% <100.00%> (-0.05%) ⬇️
rust/datafusion/src/physical_plan/sort.rs 90.17% <100.00%> (+0.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1e52b7...09b3027. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants