ARROW-11721: [Rust] json schema inference to return Schema instead of SchemaRef #9538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9538 +/- ##
=======================================
Coverage 82.27% 82.27%
=======================================
Files 244 244
Lines 55393 55393
=======================================
+ Hits 45573 45574 +1
+ Misses 9820 9819 -1
Continue to review full report at Codecov.
|
houqp
force-pushed
the
qp_json
branch
2 times, most recently
from
7a12ecf to
00302a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like there is no particular reason to return inferred schema as
SchemaRef, so I think it's more flexible and performant to returnSchemainstead, then let caller decide whether it should be wrapped into aSchemaRefor not.