ARROW-1331: [JAVA] Refactor unit tests#955
Closed
siddharthteotia wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-1331: [JAVA] Refactor unit tests#955siddharthteotia wants to merge 2 commits intoapache:masterfrom
siddharthteotia wants to merge 2 commits intoapache:masterfrom
Conversation
siddharthteotia
changed the title
Contributor
Author
|
Unit tests should not check for 0 values in fixed width vectors at positions where no data has been set. No assumption can be made about the value -- it is garbage. |
Contributor
Author
|
Does this look good? |
Contributor
Author
|
Can this be merged? |
Member
|
@icexelloss @jacques-n @StevenMPhillips can you take a look? I would probably wait until after the 0.6.0 release vote is completed to merge more patches |
Contributor
|
I scan through the changes the it looks good. But this is particular hard to review line by line. @siddharthteotia, is there anything in particular you want to be reviewed? |
Contributor
|
LGTM +1 |
asfgit
pushed a commit
that referenced
this pull request
Sep 12, 2017
TestSplitAndTransfer was merged as part of #955 However, the class did not have the package statement. This small patch fixes that. Author: siddharth <siddharth@dremio.com> Closes #1088 from siddharthteotia/ARROW-1331-fix and squashes the following commits: 78882b5 [siddharth] ARROW-1331: include package statement
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
[cc @jacques-n , @StevenMPhillips ] Refactored the java-vector unit tests in TestValueVector.java (1) Moved all the BitVector related tests to TestBitVector.java (2) Enhanced and added the tests for different vector types and grouped them into different categories in TestValueVector.java (3) Moved https://github.com/dremio/dremio-oss/blob/master/sabot/kernel/src/test/java/com/dremio/exec/vector/TestSplitAndTransfer.java to arrow. This currently has splitAndTransfer() test for NullableVarCharVector. (4) No tests have been removed -- they have either been enhanced or moved around for grouping. Recently we added splitAndTransfer tests for BitVector, UnionVector and ListVector in their respective test files. We should ideally move all the splitAndTransfer() related tests to TestSplitAndTransfer.java and should try to cover other vector types as well. A follow-up will address this (I want to keep the patch size small for easy review). Author: siddharth <siddharth@dremio.com> Closes apache#955 from siddharthteotia/ARROW-1331 and squashes the following commits: ead5cef [siddharth] ARROW-1331: Fixed unit tests 2174e65 [siddharth] ARROW-1331: Refactor unit tests
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
TestSplitAndTransfer was merged as part of apache#955 However, the class did not have the package statement. This small patch fixes that. Author: siddharth <siddharth@dremio.com> Closes apache#1088 from siddharthteotia/ARROW-1331-fix and squashes the following commits: 78882b5 [siddharth] ARROW-1331: include package statement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[cc @jacques-n , @StevenMPhillips ]
Refactored the java-vector unit tests in TestValueVector.java
(1) Moved all the BitVector related tests to TestBitVector.java
(2) Enhanced and added the tests for different vector types and grouped them into different categories in TestValueVector.java
(3) Moved https://github.com/dremio/dremio-oss/blob/master/sabot/kernel/src/test/java/com/dremio/exec/vector/TestSplitAndTransfer.java to arrow. This currently has splitAndTransfer() test for NullableVarCharVector.
(4) No tests have been removed -- they have either been enhanced or moved around for grouping.
Recently we added splitAndTransfer tests for BitVector, UnionVector and ListVector in their respective test files. We should ideally move all the splitAndTransfer() related tests to TestSplitAndTransfer.java and should try to cover other vector types as well. A follow-up will address this (I want to keep the patch size small for easy review).