ARROW-801: Provide direct access to underlying buffer memory addresses#958
Closed
siddharthteotia wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-801: Provide direct access to underlying buffer memory addresses#958siddharthteotia wants to merge 1 commit intoapache:masterfrom
siddharthteotia wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
Contributor
Author
|
Does this look good? |
Contributor
|
+1 |
siddharthteotia
force-pushed
the
ARROW-801
branch
from
2b9f4c4 to
cb6dd25
Compare
Contributor
Author
|
Squashed all 3 commits -- no new code changes pushed. |
Member
|
No need to squash, the merge tool will take care of that. Merging |
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
Added following methods at FieldVector interface public long getValidityBufferAddress(); public long getDataBufferAddress(); public long getOffsetBufferAddress(); Couple of points: For the UnionVector, we don't have an explicit BitVector and the typeVector also acts as a validity vector during get(), isNull(). So getValidityBufferAddress() returns the address of buffer associated with typeVector. Both ListVector and FixedSizeListVector are backed by a FieldVector which acts as the dataVector. Right now the getDataBufferAddress() is unsupported for these two vectors but I think that we could just simply delegate this call to the dataVector instead of throwing exception Author: siddharth <siddharth@dremio.com> Closes apache#958 from siddharthteotia/ARROW-801 and squashes the following commits: cb6dd25 [siddharth] ARROW-801: Provide direct access to underlying buffer memory addresses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added following methods at FieldVector interface
public long getValidityBufferAddress();
public long getDataBufferAddress();
public long getOffsetBufferAddress();
Couple of points:
For the UnionVector, we don't have an explicit BitVector and the typeVector also acts as a validity vector during get(), isNull(). So getValidityBufferAddress() returns the address of buffer associated with typeVector.
Both ListVector and FixedSizeListVector are backed by a FieldVector which acts as the dataVector. Right now the getDataBufferAddress() is unsupported for these two vectors but I think that we could just simply delegate this call to the dataVector instead of throwing exception