ARTEMIS-1780 Handle conversion of large ObjectMessage types#1985
Closed
tabish121 wants to merge 1 commit into
Closed
ARTEMIS-1780 Handle conversion of large ObjectMessage types#1985tabish121 wants to merge 1 commit into
tabish121 wants to merge 1 commit into
Conversation
Contributor
|
nice catch, but There are test failures on the PR that are apparently real. @tabish121 can you look please? |
Contributor
Author
|
I updated the patch to remove the duplicate decode which seems to have been the root cause of the other test failure. |
Contributor
|
@tabish121 this passed earlier today and failed now... Can you rebase (change the commit id) just to force another build please? |
Make sure the correct buffer is used when decoding the stored Core message that originated from the conversion of an AMQP message sent and annotated as a JMS ObjectMessage which trips the large message boundary.
Contributor
Author
|
That's twice now today I've rebased. Test failure doesn't seem related to AMQP |
Contributor
|
Thanks a lot. I will check what’s going on. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure the correct buffer is used when decoding the stored Core
message that originated from the conversion of an AMQP message sent and
annotated as a JMS ObjectMessage which trips the large message boundary.