fix: keep release candidates off crates.io - #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo publish --dry-run.${VERSION}-rc.${RC}Cargo version, manifest rewrite, and--allow-dirtypath from the release workflow and runbook.Design Notes
ASF release candidates are identified by the signed RC tag and the ASF staging directory, not by a separately versioned crate. The publish job runs only when the pushed ref exactly matches the final
v${VERSION}tag produced after the release votes.Validation
cargo x checkcargo x test --no-captureRUSTUP_TOOLCHAIN=1.86.0 cargo x test --no-capturecargo x semver --release-version 0.7.2cargo publish --package asyncband --locked --dry-runRUSTDOCFLAGS="-D warnings --cfg docsrs" cargo +nightly doc --workspace --all-features --no-depstyposhawkeye checkgit diff --checkcargo x lintpassed Clippy and rustfmt before the local Taplo 0.10.0 process hit its known macOSsystem-configurationNULL-object panic; the remaining lint checks were run separately as listed above.