ATLAS-5333: Atlas React UI: Clearing a Classification search filter triggers 400 Bad Request on empty parameters#692
Merged
Conversation
…riggers 400 Bad Request on empty parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes an issue where clearing a Classification search filter triggered a 400 Bad Request error.
Root Cause:
When navigating to classification searches from the Dashboard (e.g., Overview Card, Classification Types in Use),
dashboardSearchUtils.tswas explicitly appending an emptytype=""parameter to the search URL. When a user subsequently cleared the classification filter via the "X" button,FilterQuery.tsxincorrectly detected the danglingtype=parameter as a "meaningful" filter. This caused the UI to fire an empty search request to the backend instead of safely resetting the search state.Fix:
Removed the explicit injection of
params.set("type", "");insrc/utils/dashboardSearchUtils.tswhen building classification URLs. By preventing the emptytypeparameter from being added,FilterQuerynow correctly identifies when zero meaningful filters remain, safely navigating the user back to the default/searchpage without throwing a 400 error.How was this patch tested?
Manual testing performed:
Classificationscount link inside the Overview card./searchpage without throwing a400 Bad Requestbackend error.npm run buildcompletes successfully with no regressions.