[AURON #2158] fix: change const to static in batch_size() to fix OnceCell caching#2159
Open
yew1eb wants to merge 1 commit intoapache:masterfrom
Open
[AURON #2158] fix: change const to static in batch_size() to fix OnceCell caching#2159yew1eb wants to merge 1 commit intoapache:masterfrom
yew1eb wants to merge 1 commit intoapache:masterfrom
Conversation
yew1eb
changed the title
…x OnceCell caching Fixes AURON-2158. The const OnceCell was creating a new instance on every call, causing the cache to never hit.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a caching bug in batch_size() where using a const OnceCell resulted in a fresh cell per call, preventing cache hits.
Changes:
- Replaced
const CACHED_BATCH_SIZE: OnceCell<usize>withstatic CACHED_BATCH_SIZE: OnceCell<usize>inbatch_size()so the cached value persists across calls.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AURON-2158. The const OnceCell was creating a new instance on every call, causing the cache to never hit.
Which issue does this PR close?
Closes #2158
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
How was this patch tested?