[AURON #2208] correctness testing: setup correctness testing scaffolding for all spark versions#2209
Merged
ShreyeshArangath merged 1 commit intoApr 20, 2026
Conversation
Introduce empty test modules for Spark 3.1/3.2/3.4/3.5/4.0/4.1 alongside the existing spark33 module. Each module ships only a Maven pom and an empty AuronSparkTestSettings stub so that profile activation and the reflection lookup in common/SparkTestSettings both succeed. Per-area suites (Aggregate/Sort/Parquet/Functions/Expressions) will land in separate follow-up PRs tracked under apache#2170-apache#2174.
ShreyeshArangath
changed the title
ShreyeshArangath
marked this pull request as ready for review
April 20, 2026 03:25
cxzl25
approved these changes
Apr 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds correctness-testing scaffolding for additional Spark versions by introducing new auron-spark-tests submodules (Spark 3.1/3.2/3.4/3.5/4.0/4.1) and wiring them into Maven profiles so profile activation and the SparkTestSettings reflection lookup succeed across versions.
Changes:
- Added new
auron-spark-testssubmodules for Spark 3.1, 3.2, 3.4, 3.5, 4.0, and 4.1 with module-localpom.xml. - Added per-module
AuronSparkTestSettingsstubs for the new Spark versions. - Updated
auron-spark-tests/pom.xmlto include new Spark-version profiles/modules.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| auron-spark-tests/pom.xml | Adds Maven profiles to include the new Spark-version test modules. |
| auron-spark-tests/spark31/pom.xml | New Spark 3.1 test module POM mirroring spark33 structure. |
| auron-spark-tests/spark31/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala | Spark 3.1 settings stub for reflection-based settings loading. |
| auron-spark-tests/spark32/pom.xml | New Spark 3.2 test module POM mirroring spark33 structure. |
| auron-spark-tests/spark32/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala | Spark 3.2 settings stub for reflection-based settings loading. |
| auron-spark-tests/spark34/pom.xml | New Spark 3.4 test module POM mirroring spark33 structure. |
| auron-spark-tests/spark34/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala | Spark 3.4 settings stub for reflection-based settings loading. |
| auron-spark-tests/spark35/pom.xml | New Spark 3.5 test module POM mirroring spark33 structure. |
| auron-spark-tests/spark35/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala | Spark 3.5 settings stub for reflection-based settings loading. |
| auron-spark-tests/spark40/pom.xml | New Spark 4.0 test module POM mirroring spark33 structure. |
| auron-spark-tests/spark40/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala | Spark 4.0 settings stub for reflection-based settings loading. |
| auron-spark-tests/spark41/pom.xml | New Spark 4.1 test module POM mirroring spark33 structure. |
| auron-spark-tests/spark41/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala | Spark 4.1 settings stub for reflection-based settings loading. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
All the above are expected, as this is only adding the scaffolding |
yew1eb
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Introduce empty test modules for Spark 3.1/3.2/3.4/3.5/4.0/4.1 alongside the existing spark33 module. Each module ships only a Maven pom and an empty AuronSparkTestSettings stub so that profile activation and the reflection lookup in common/SparkTestSettings both succeed.
Closes #2208
Rationale for this change
N/A
What changes are included in this PR?
Scaffolding for correctness tests
Are there any user-facing changes?
N/A
How was this patch tested?
Unit tests