[AURON #2246] Reuse Hudi table properties when detecting native scan support#2247
Merged
Merged
Conversation
weimingdiit
force-pushed
the
feat/hudi-reues-properties
branch
from
May 10, 2026 02:44
50588cc to
5155399
Compare
weimingdiit
marked this pull request as ready for review
May 10, 2026 03:18
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors Hudi native scan support detection to avoid duplicated reads of .hoodie/hoodie.properties by introducing a shared properties loader and reusing the loaded Properties when resolving table type and base file format.
Changes:
- Added a shared helper to load Hudi table properties from metadata once (with
Using.resourcefor stream management). - Reused the loaded table properties to resolve Hudi table type and base file format during support detection.
- Introduced
supportedFileFormatand updatedHudiConvertProviderto reuse the resolved supported format when selecting native Parquet vs ORC scan conversion.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| thirdparty/auron-hudi/src/main/scala/org/apache/spark/sql/auron/hudi/HudiScanSupport.scala | Adds shared hoodie.properties loader and threads the resulting Properties through file format + support detection. |
| thirdparty/auron-hudi/src/main/scala/org/apache/spark/sql/auron/hudi/HudiConvertProvider.scala | Switches to supportedFileFormat for support checks and to select the correct native scan implementation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… scan support Signed-off-by: weimingdiit <weimingdiit@gmail.com>
weimingdiit
force-pushed
the
feat/hudi-reues-properties
branch
from
May 10, 2026 11:34
5155399 to
dcdfd47
Compare
slfan1989
approved these changes
May 13, 2026
yew1eb
approved these changes
May 13, 2026
Contributor
|
@weimingdiit Thanks for the contribution! Merged. @yew1eb Thanks for the review! |
Contributor
Author
|
@yew1eb @slfan1989 Thanks for your review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2246
Rationale for this change
Hudi native scan support detection may need to read
.hoodie/hoodie.propertiesto resolve table type and base file format. Before this change, these two pieces of metadata were loaded through separate code paths, which duplicated the file loading logic.What changes are included in this PR?
.hoodie/hoodie.properties.Using.resourceto manage the metadata input stream.HudiConvertProvider.Are there any user-facing changes?
No. This is an internal refactor for Hudi native scan support detection.
How was this patch tested?
CI. Existing Hudi scan support tests should cover the behavior.