[AURON #2501] Support datediff function natively - #2502
Open
Sigma-Ma wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The native datediff implementation/conversion currently lacks session-timezone handling for timestamp inputs, which can yield incorrect results vs Spark in non-UTC timezones.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adds native execution support for Spark SQL datediff(endDate, startDate) by converting Spark DateDiff expressions into Auron extension functions and implementing Spark_DateDiff in the native DataFusion extension layer, along with regression/unit test coverage.
Changes:
- Convert Spark
DateDiffexpressions to theSpark_DateDiffextension function inNativeConverters. - Register
Spark_DateDiffin the native extension function factory and implement its Date32 signed-day difference logic with null propagation. - Add regression coverage in
AuronFunctionSuiteand Rust unit tests for coredatediffcases.
File summaries
| File | Description |
|---|---|
| spark-extension/src/main/scala/org/apache/spark/sql/auron/NativeConverters.scala | Adds conversion of Spark DateDiff to Spark_DateDiff extension function. |
| spark-extension-shims-spark/src/test/scala/org/apache/auron/AuronFunctionSuite.scala | Adds Spark-vs-native regression test for datediff. |
| native-engine/datafusion-ext-functions/src/spark_dates.rs | Implements spark_datediff and adds Rust unit test coverage. |
| native-engine/datafusion-ext-functions/src/lib.rs | Registers Spark_DateDiff in the extension-function dispatch table. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+300
to
+321
| pub fn spark_datediff(args: &[ColumnarValue]) -> Result<ColumnarValue> { | ||
| let dates = ColumnarValue::values_to_arrays(args)?; | ||
| let end_date = cast(&dates[0], &DataType::Date32)?; | ||
| let start_date = cast(&dates[1], &DataType::Date32)?; | ||
| let end_date = end_date | ||
| .as_any() | ||
| .downcast_ref::<Date32Array>() | ||
| .expect("cast to Date32 must succeed"); | ||
| let start_date = start_date | ||
| .as_any() | ||
| .downcast_ref::<Date32Array>() | ||
| .expect("cast to Date32 must succeed"); | ||
| let result = Int32Array::from_iter(end_date.iter().zip(start_date.iter()).map( | ||
| |(end_date, start_date)| { | ||
| end_date | ||
| .zip(start_date) | ||
| .map(|(end_date, start_date)| end_date.wrapping_sub(start_date)) | ||
| }, | ||
| )); | ||
|
|
||
| Ok(ColumnarValue::Array(Arc::new(result))) | ||
| } |
Comment on lines
+1005
to
+1006
| case e: DateDiff => | ||
| buildExtScalarFunction("Spark_DateDiff", e.children, e.dataType) |
Comment on lines
+218
to
+220
| checkSparkAnswerAndOperator( | ||
| "select datediff(end_date, start_date), datediff(end_date, date'2024-01-01') from t1") | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2501
Rationale for this change
Spark
DateDiffexpressions are not currently converted to native expressions, so queries usingdatediffremain on the fallback path.This change adds native execution while preserving Spark's argument order, signed day difference, and null behavior.
What changes are included in this PR?
DateDiffexpressions inNativeConvertersSpark_DateDiffextension functionAuronFunctionSuiteAre there any user-facing changes?
No. The SQL syntax and result semantics remain unchanged. Eligible
datediffexpressions can now execute natively.How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-5)
ASF guidance: https://www.apache.org/legal/generative-tooling.html