AVRO-2898: Build failure without a C++ compiler (again) #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avro-c fails to build (again) without a C++ compiler because commit 664c2fc reverted the change made by commit 414a51f Fixes: - http://autobuild.buildroot.org/results/cfa91db53cf5502cbb6f902d1e7ad6397c8d70fd Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Contributor
|
Hey, thanks for following up on this! @kraj was reverting this change deliberate? I'm not super familiar with cmake, but this PR looks like the right thing to do. |
Contributor
this change is not intentional, in fact the pull I see here f42f97c |
RyanSkraba
referenced
this pull request
Jan 20, 2021
This ensures that it can be built on platforms where libdir is not /usr/lib e.g. ppc64 Signed-off-by: Khem Raj <raj.khem@gmail.com> Closes #749
RyanSkraba
approved these changes
Jan 20, 2021
RyanSkraba
pushed a commit
that referenced
this pull request
Jan 20, 2021
avro-c fails to build (again) without a C++ compiler because commit 664c2fc reverted the change made by commit 414a51f Fixes: - http://autobuild.buildroot.org/results/cfa91db53cf5502cbb6f902d1e7ad6397c8d70fd Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Contributor
|
Thanks for finding this mistake! I cherry-picked this to branch-1.10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avro-c fails to build (again) without a C++ compiler because commit 664c2fc reverted the change made by commit 414a51f
Fixes:
Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com