AVRO-2998: Schema validation for Ruby hashes with symbol keys #1036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AVRO-2749 added support for serializing hashes with symbol keys but they were still considered invalid. This fixes schema validation to also accept hashes with symbol keys.
jturkel
force-pushed
the
feature/symbol-keys
branch
from
c0650a5 to
a2377ec
Compare
Contributor
Author
|
@tjwp - I rebased this to pick up the switch to use Github Actions for CI. Looks like tests are passing now 🎉 |
RyanSkraba
pushed a commit
to RyanSkraba/avro
that referenced
this pull request
Mar 3, 2021
AVRO-2749 added support for serializing hashes with symbol keys but they were still considered invalid. This fixes schema validation to also accept hashes with symbol keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVRO-2749 added support for serializing Ruby hashes with symbol keys but they were still considered invalid. This PR fixes schema validation to also accept hashes with symbol keys.
/cc @tjwp