Skip to content

AVRO-3006: Documentation for Pypi Packages #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kojiromike merged 4 commits into from
Dec 21, 2020
Merged

AVRO-3006: Documentation for Pypi Packages #1041

kojiromike merged 4 commits into from
Dec 21, 2020

Conversation

@kojiromike
Copy link
Contributor

@kojiromike kojiromike commented Dec 18, 2020 •
edited
Loading

Jira

  • References the ticket AVRO-3006.
  • Adds no dependencies.

Tests

  • Documentation change requiring no tests.

Commits

  • …all reference the Jira issue.
  • …follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • …is all this is

cewing
cewing reviewed Dec 18, 2020
View reviewed changes
Copy link
Contributor

@cewing cewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! Thanks especially for the deprecation notice in the py3 package.

@kojiromike kojiromike merged commit ca6d72d into apache:master Dec 21, 2020
@kojiromike kojiromike deleted the AVRO-3006-pypi-documentation branch December 21, 2020 02:02
RyanSkraba pushed a commit to RyanSkraba/avro that referenced this pull request Mar 3, 2021
@kojiromike @RyanSkraba
AVRO-3006: Documentation for Pypi Packages (apache#1041)
5c05601 
* AVRO-3006: Update Pypi Docs for py3

* AVRO-3006: Make py3 README a Markdown File

* AVRO-3006: Add README for lang/py

* AVRO-3006: Add Development Status Trove Classifiers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cewing cewing cewing left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Python Python3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kojiromike @cewing