Skip to content

AVRO-3041: use default converters for unions/nullable properties#1088

Open
Gonyoda wants to merge 5 commits intoapache:mainfrom
Snagajob:nullable-converters
Open

AVRO-3041: use default converters for unions/nullable properties#1088
Gonyoda wants to merge 5 commits intoapache:mainfrom
Snagajob:nullable-converters

Conversation

@Gonyoda
Copy link
Copy Markdown

@Gonyoda Gonyoda commented Feb 11, 2021

Jira

Tests

  • My PR adds the following unit tests
  • SerializeNullableWithNullableConverter
  • SerializeNullableDefaultWithClass
  • SerializeNullableDefaultWithDelegate
  • SerializeNullableDefaultWithNullableDelegate
  • SerializeNullableDefaultWithDoubleNullableDelegate

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.

@github-actions github-actions bot added the C# label Feb 11, 2021
@RyanSkraba RyanSkraba changed the title AVRO-3041 : use default converters for unions/nullable properties AVRO-3041: use default converters for unions/nullable properties Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant