Add FreeBSD way of byte-swapping uint32#110
Merged
asfgit merged 1 commit intoapache:masterfrom Jan 29, 2017
AMDmi3:freebsd-bswap
Merged
Add FreeBSD way of byte-swapping uint32#110asfgit merged 1 commit intoapache:masterfrom AMDmi3:freebsd-bswap
asfgit merged 1 commit intoapache:masterfrom
AMDmi3:freebsd-bswap
Conversation
Contributor
|
@thiru-apache, can you take a look at this? It's a pretty small patch. |
Contributor
Contributor
|
@rdblue/@AMDmi3, Looks good to me. Will merge it once the ticket is created. |
Contributor
|
@AMDmi3 do you have an ASF JIRA user id? I can file the issue, but would prefer to credit you in the assignee field. |
Contributor
Author
|
I don't care of being credited and would prefer not to deal with JIRA in any way. |
iemejia
pushed a commit
that referenced
this pull request
Jun 11, 2021
#110) * Added support for enums * added serializer test * Added tests and fixed issues with the variant serialization * added failing tests for de. Fixed test for ser * Fully completed initial implementation * Fixed warnings * Changed the code to be more idiomatic * Fixed some error message * Changed structure so that it can work for deserialization * Removed unused test * Removed unused structs * Update src/de.rs Co-Authored-By: Katie <codehearts@users.noreply.github.com> * Running cargo fmt Co-authored-by: Jean-Mathieu Deschenes <deschenes.j.m@gmail.com> Co-authored-by: Calvin Brown <calvinb085@icloud.com> Co-authored-by: Katie <codehearts@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.