Skip to content

AVRO-3056: Bump zstd-jni from 1.4.8-4 to 1.4.8-6 in /lang/java#1105

Closed
dongjoon-hyun wants to merge 2 commits intoapache:masterfrom
dongjoon-hyun:AVRO-3056
Closed

AVRO-3056: Bump zstd-jni from 1.4.8-4 to 1.4.8-6 in /lang/java#1105
dongjoon-hyun wants to merge 2 commits intoapache:masterfrom
dongjoon-hyun:AVRO-3056

Conversation

@dongjoon-hyun
Copy link
Copy Markdown
Member

@dongjoon-hyun dongjoon-hyun commented Feb 27, 2021

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    This is a dependency update and it should pass all the existing unit tests.

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@github-actions github-actions bot added build Java Pull Requests for Java binding labels Feb 27, 2021
@dongjoon-hyun
Copy link
Copy Markdown
Member Author

dongjoon-hyun commented Feb 27, 2021

Could you review this please, @iemejia ?

@Fokko
Copy link
Copy Markdown
Contributor

Fokko commented Feb 28, 2021

I'm missed this PR, and already merged the one by Dependabot: #1111. However, huge thanks for pointing out the breaking compatibility, and providing a PR.

@Fokko Fokko closed this Feb 28, 2021
@iemejia
Copy link
Copy Markdown
Member

iemejia commented Feb 28, 2021

Thanks @dongjoon-hyun great to see this getting aligned here too. I assigned the ticket to you and let it open so we can track it as part of the 1.10.2 Avro release

CC @RyanSkraba for awareness

@dongjoon-hyun
Copy link
Copy Markdown
Member Author

No problem. Thanks, @Fokko and @iemejia .

@dongjoon-hyun dongjoon-hyun deleted the AVRO-3056 branch February 28, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Java Pull Requests for Java binding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants