Skip to content

AVRO-3070: Temporarily deactivate c++ lint#1141

Closed
RyanSkraba wants to merge 1 commit intoapache:masterfrom
RyanSkraba:AVRO-3070-no-cppcheck
Closed

AVRO-3070: Temporarily deactivate c++ lint#1141
RyanSkraba wants to merge 1 commit intoapache:masterfrom
RyanSkraba:AVRO-3070-no-cppcheck

Conversation

@RyanSkraba
Copy link
Copy Markdown
Contributor

Temporary workaround Github actions while the c++ lint stage is failing.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@github-actions github-actions bot added build C++ Pull Requests for C++ binding labels Mar 18, 2021
@RyanSkraba RyanSkraba closed this Mar 22, 2021
@RyanSkraba RyanSkraba deleted the AVRO-3070-no-cppcheck branch March 22, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build C++ Pull Requests for C++ binding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant