Skip to content

AVRO-3004 Drop support for Python 3.5#1151

Merged
kojiromike merged 2 commits intoapache:masterfrom
subhashb:3004-drop-py3.5-support
Mar 25, 2021
Merged

AVRO-3004 Drop support for Python 3.5#1151
kojiromike merged 2 commits intoapache:masterfrom
subhashb:3004-drop-py3.5-support

Conversation

@subhashb
Copy link
Copy Markdown
Contributor

This PR removes 3.5 support from build and setup, including classifiers

Closes: AVRO-3004 (https://issues.apache.org/jira/browse/AVRO-3004)

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    NA

This PR removes 3.5 support from build and setup, including classifiers

Closes: AVRO-3004 (https://issues.apache.org/jira/browse/AVRO-3004)
Copy link
Copy Markdown
Contributor

@kojiromike kojiromike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add 3.9 now? I think it will just work.

Also, we might need to remove 3.5 and add 3.9 to the GitHub actions matrix

@subhashb
Copy link
Copy Markdown
Contributor Author

Can we add 3.9 now? I think it will just work.

Also, we might need to remove 3.5 and add 3.9 to the GitHub actions matrix

Done and tests pass.
Actually, Github actions were not testing for 3.5 and in turn had pypy3.7 tests. I have added pypy3.7 to tox envs.

Copy link
Copy Markdown
Contributor

@RyanSkraba RyanSkraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This almost LGTM -- it seems the docker image that we use for releases (based on debian stretch) is still 3.5.3 and there isn't any 3.6 available for it.

You can merge this safely now, but the next release is going to need a fix to the environment!

@kojiromike
Copy link
Copy Markdown
Contributor

@RyanSkraba the mega base image is always going to be a sticking point. We have looked at nektos/act as a substitute, but it isn't free from trouble.

@kojiromike kojiromike merged commit 5bd7cfe into apache:master Mar 25, 2021
@subhashb subhashb deleted the 3004-drop-py3.5-support branch March 25, 2021 15:50
@RyanSkraba
Copy link
Copy Markdown
Contributor

For reference, I created https://issues.apache.org/jira/browse/AVRO-3092 to discuss that issue and PR#1155 for a quick fix! But we can probably do better for a long-term solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants