Skip to content

AVRO-2838: Conditional Java String type schema modification#1235

Open
slominskir wants to merge 1 commit intoapache:mainfrom
slominskir:patch-1
Open

AVRO-2838: Conditional Java String type schema modification#1235
slominskir wants to merge 1 commit intoapache:mainfrom
slominskir:patch-1

Conversation

@slominskir
Copy link

@slominskir slominskir commented May 24, 2021

Add option to skip the schema mangling step in the Java AVRO compiler that breaks compatibility between Java and Python (and other languages).

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    • org.apache.avro.compiler.specific.TestSpecificCompiler.java#testSettingDoNotModifySchema

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@github-actions github-actions bot added the Java Pull Requests for Java binding label May 24, 2021
@slominskir slominskir force-pushed the patch-1 branch 3 times, most recently from 9e63296 to 92baebd Compare May 25, 2021 18:58
@slominskir slominskir marked this pull request as ready for review May 25, 2021 18:58
@kojiromike kojiromike changed the title Conditional Java String type schema modification AVRO-2838: Conditional Java String type schema modification May 28, 2021
Add option to skip the schema mangling step in the Java AVRO
compiler that breaks compatibility with other languages
@slominskir
Copy link
Author

Ran "mvn spotless:apply" to correct formatting then force pushed (squashed changes to keep single commit with required message prefix)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java Pull Requests for Java binding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant