Skip to content

AVRO-2921: Incremental Type Hints for avro.schema#1252

Merged
kojiromike merged 1 commit intoapache:masterfrom
kojiromike:AVRO-2921/mypy3
Jun 10, 2021
Merged

AVRO-2921: Incremental Type Hints for avro.schema#1252
kojiromike merged 1 commit intoapache:masterfrom
kojiromike:AVRO-2921/mypy3

Conversation

@kojiromike
Copy link
Contributor

@kojiromike kojiromike commented Jun 9, 2021

Add type hints to avro.schema while ensuring no breaking changes.

Jira

Tests

  • Adds type checks

Commits

  • Reference AVRO-2921 in their subject lines.
  • Follow the guidelines from "How to write a good git commit message":
    • Subject is separated from body by a blank line
    • Subject is limited to 50 characters (not including Jira issue reference)
    • Subject does not end with a period
    • Subject uses the imperative mood ("add", not "adding")
    • Body wraps at 72 characters
    • Body explains "what" and "why", not "how"

Documentation

N/A

@github-actions github-actions bot added the Python label Jun 9, 2021
@kojiromike kojiromike merged commit 6dc6055 into apache:master Jun 10, 2021
@kojiromike kojiromike deleted the AVRO-2921/mypy3 branch June 10, 2021 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kojiromike