Skip to content

AVRO-3190: Error when trying to read 0 bytes at eof#1314

Merged
RyanSkraba merged 4 commits intoapache:masterfrom
RyanSkraba:Skeeve/AVRO-3190-perl-eof
Aug 27, 2021
Merged

AVRO-3190: Error when trying to read 0 bytes at eof#1314
RyanSkraba merged 4 commits intoapache:masterfrom
RyanSkraba:Skeeve/AVRO-3190-perl-eof

Conversation

@RyanSkraba
Copy link
Contributor

(Reopened #1313, thanks @Skeeve and @martin-g)

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

Skeeve and others added 3 commits August 24, 2021 13:15
When reading an avro file record for record each time when reading the last record DataFileReader tries to get the next block but (of course) fails. This fixes the issue.
@github-actions github-actions bot added the Perl label Aug 24, 2021
@RyanSkraba RyanSkraba merged commit 6a1d0f3 into apache:master Aug 27, 2021
@RyanSkraba RyanSkraba deleted the Skeeve/AVRO-3190-perl-eof branch August 27, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants