AVRO-1928: Simplify Python float/double encoding#132
Closed
shalabhc wants to merge 1 commit intoapache:masterfrom
Closed
AVRO-1928: Simplify Python float/double encoding#132shalabhc wants to merge 1 commit intoapache:masterfrom
shalabhc wants to merge 1 commit intoapache:masterfrom
Conversation
Switch to using built-in little endian support in the struct module, instead of explicit bit manipulation. All tests pass.
johnsgill3
reviewed
May 13, 2017
Contributor
johnsgill3
left a comment
johnsgill3
left a comment
There was a problem hiding this comment.
Has this been integration tested against other various languages (Eg. java) to make sure that Object Container Files written in one language are still readable in another?
Author
|
It passes all the Avro tests which verified that this does not change the actual binary data produced. I'm not aware of any cross language integration tests. |
Contributor
|
@shalabhc If you still want to get this in, please resolve the conflicts. |
iemejia
pushed a commit
that referenced
this pull request
Jun 11, 2021
This is in line with other buffer implementations out there, like https://doc.rust-lang.org/std/io/struct.BufWriter.html#method.into_inner
SingingBush
pushed a commit
to SingingBush/avro
that referenced
this pull request
Jun 29, 2023
Add support for configuration cache and update kotlin testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to using built-in little endian support in the struct
module, instead of explicit bit manipulation.
All tests pass.