Skip to content

Conversation

@vegraux
Copy link
Contributor

@vegraux vegraux commented Oct 6, 2021

Make sure you have checked all steps below.

Jira

  • My PR addresses the following AVRO-3218 issue

Tests

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@github-actions github-actions bot added the Python label Oct 6, 2021
@vegraux vegraux force-pushed the AVRO-3218_fix_python_parsing_of_decimal_logical_type branch from 4ad2019 to fa6b8b4 Compare October 6, 2021 14:34
@vegraux
Copy link
Contributor Author

vegraux commented Oct 6, 2021

@martin-g I fixed the lint-issue and amended to the same commit

@vegraux
Copy link
Contributor Author

vegraux commented Oct 8, 2021

@martin-g How is the timeline for merging?

@martin-g
Copy link
Member

martin-g commented Oct 8, 2021

I am not a member of Apache Avro team. I am just a contributor who helps in areas I have some knowledge.
Apache Avro 1.11.0 rc1 is being voted at the moment at dev@.
So this PR will have to wait for 1.11.1/1.12.0.

@RyanSkraba RyanSkraba changed the title AVRO-3218 Fix parsing of logicalType = decimal AVRO-3218: Fix parsing of logicalType = decimal Oct 15, 2021
@vegraux
Copy link
Contributor Author

vegraux commented Nov 30, 2021

@RyanSkraba Is there a place I can check to see what is planned to be included in future releases? Would really appreciate to get this in 1.11.1, it is a really annoying bug

@martin-g
Copy link
Member

The way to schedule something for a specific release is to set the "Fix Version" in the JIRA ticket.
This way the ticket will be reviewed before the release. If everything is clear and the PR is approved then it will be resolved. Otherwise the Fix Version will be edited.
In both cases the release manager will take your ticket into account when the release time comes.
Depending on how many tickets are fixed and what kind of changes are applied with them it might be versioned as 1.11.1 or 1.12.0.

@kojiromike
Copy link
Contributor

I don't think we have a policy that says that merging a PR has to wait for a specific release. The actual release process uses different branches. So I'm happy to merge this now, and then if the ticket says this bugfix needs to go into 1.11.1 then it can.

@kojiromike kojiromike merged commit 57e0bbf into apache:master Dec 18, 2021
RyanSkraba pushed a commit that referenced this pull request Dec 20, 2021
Co-authored-by: Vegard Solberg <vegard.solberg@statnett.no>
@cccs-eric
Copy link

@martin-g I just ran into this issue and wanted to contribute a fix when I discovered that master already contains a fix! Would it be possible to know when 1.11.1 will be released? This is a blocker for me....

@martin-g
Copy link
Member

There is a mail thread about this at dev@ mailing list.
I hope it will be released soon!

@vegraux
Copy link
Contributor Author

vegraux commented Jun 2, 2022

@RyanSkraba When is the next release (1.11.1) planned? I must manually build avro with the bugfix, and push to my company's artifactory to get around this. It often causes dependency problems

@vegraux
Copy link
Contributor Author

vegraux commented Jun 15, 2022

There is a mail thread about this at dev@ mailing list. I hope it will be released soon!

Do you have an update on the release @martin-g?

@martin-g
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants