Skip to content

Conversation

@RyanSkraba
Copy link
Contributor

The node.js tests were fixed for the "Active LTD" version 14 in AVRO-3171 but not yet for later versions. The Dockerfile build should target this version until the version 16 fixes are done.

Jira

Tests

  • My PR does not need testing for this extremely good reason: Validated manually building release candidates.

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@github-actions github-actions bot added the build label Oct 6, 2021
@RyanSkraba RyanSkraba merged commit 0789cb7 into apache:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant