AVRO-3248 Rust: Support named types in UnionSchema#1393
Closed
martin-g wants to merge 2 commits intoapache:masterfrom
Closed
AVRO-3248 Rust: Support named types in UnionSchema#1393martin-g wants to merge 2 commits intoapache:masterfrom
martin-g wants to merge 2 commits intoapache:masterfrom
Conversation
Drop the index map in UnionSchema. It is not common to have many schemata in the union. Usually it is either "null"+otherType or just a few of otherType. Iterating over a short list is not that slow
Contributor
|
Sorry, i missied your message, somehow it did't send the notification by email :P I checked and ur solution seems to be wrong if we have a union like this ["A", "B"] where A and B are like this -- in this case, the schema found by a value will always be "A"'s schema. this also applies to A, B being "fixed" type, which seems plausible in reallife (for example here is my PR for these scenario . #1396 to solve that, we can change |
Member
Author
|
Closed in favour of #1396 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the index map in UnionSchema. It is not common to have many schemata in the union. Usually it is either "null"+otherType or just a few of otherType. Iterating over a short list is not that slow
Jira
Tests
Commits